feat(engine): add feature for trait item defaults #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
approved these changes
Aug 6, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #624 in the importer.
This PR adds a
TIDefaultvariant totrait_item'in the AST to support trait items with default values/implementations.Currently, only defaults in
constandfnare supported whereconsts are encoded with a arity-0 function just like normal trait items.Defaults for associated types are not currently supported as they are still an unstable feature in upstream rust rust-lang/rust#29661.
This addition is feature gated with the
trait_item_defaultfeature and all backends have been adjusted to reject this feature for the moment.